I'm always looking on how to improve my code (in general, no matter what the programming language is), although it's certainly true Python is one in a million because of many reasons, one of them being that a bunch of design patterns are an intrinsic part of the language, such as decorators and context managers.
More specifically, i was looking for a way to run my tools regardless or whether it was standalone (this is, running its own QtApplication, or embedded into Maya's). In the past, i didnt have much time to dig into this and consequently, i used two separate launchers.
Last week this was solved by the use of a context manager. I realised i could make good use of it, since in both cases (running standalone or in a host app) i had to make the same two calls:
tool_window = Gui_class(parent)
tool_window.show()
Where Gui_class() is the main GUI PyQt Class. The difference is the parent argument where in one case it must be None and in the other it must be a pointer to the Maya GUI Main Window.
This difference in the parent argument could be handled just the same way as for example the open() context manager works:
with open(filepath, 'wb') as f:
src_lines = f.readlines()
In this case, the advantage is the user doesnt have to remember to close the file stream and the open() method yields the stream as 'f'.
LAUNCHER IMPLEMENTATION
@contextlib.contextmanager
def application():
if not QtGui.qApp:
app = QtGui.QApplication(sys.argv)
parent = None
yield parent
app.exec_()
else:
parent = get_maya_main_window()
yield parent
This is my implementation of my custom context manager, it is basically an if statement that checks whether the tool is being lauched from a host application or in his own QApplication. This function could be already the main launcher, the only need is to put the previous two lines showed where the yield statement goes. But this goes against one of the OOP principles, Dont Repeat Yourself (DRY).
So if we push a little bit further we end up with:
def launcher(cls):
with application() as e:
window = cls(parent=e)
window.show()
Where cls is the name of the main GUI class. This way, we have an agnostic launcher prepared to work as standalone and within a host app like maya.
Needless to say that some pieces of the tool only will work inside Maya but this way at least we can launch the tool for GUI refinement and development.
No more separate launchers with duplicate parts of the code!!
No hay comentarios:
Publicar un comentario